magento2-cron-scheduler icon indicating copy to clipboard operation
magento2-cron-scheduler copied to clipboard

Breaking changes in 1.0.7+ to magento CE 2.3.3 < : Class Magento\Cron\Model\DeadlockRetrierInterface does not exist

Open ProxiBlue opened this issue 4 years ago • 1 comments

Preconditions

  1. Ensure install of magento 2.3.3-p1 (via composer)
  2. Ensure install of 1.0.7+ of this module via composer ("kiwicommerce/module-cron-scheduler": "^1.0")

Steps to reproduce

  1. run ./bin/magento setup:di:compile

Expected result

Compile should complete

Actual result

03:30 $ ./bin/magento setup:di:compile
Compilation was started.
Area configuration aggregation... 5/7 [====================>-------]  71% 32 secs 476.0 MiB
In ClassReader.php line 35:
                                                                    
  Class Magento\Cron\Model\DeadlockRetrierInterface does not exist  
                                                                    

In ClassReader.php line 29:
                                                                    
  Class Magento\Cron\Model\DeadlockRetrierInterface does not exist  
                                                                    

setup:di:compile

  • Quick Fix (in a pinch): Lock composer to 1.0.6 for m2.3.3 < "kiwicommerce/module-cron-scheduler": "1.0.6"

compile then works

3:41 $ ./bin/magento setup:di:compile
Compilation was started.
Interception cache generation... 7/7 [============================] 100% 49 secs 622.0 MiB
Generated code and dependency injection configuration successfully.

Comments: Personally, I think it will be appropriate to move 1.0.7 and 1.0.8 releases to 1.1.0 and 1.1.1 respectively, with appropriate adjustments to composer to prevent install in m< 2.3.5 ? (have not tested to which version this issue goes, I have 2.3.3-p1 on this client)

having originally used "kiwicommerce/module-cron-scheduler": "^1.0" should have prevented breaking chnages in the given version series. (1.0)

ProxiBlue avatar Oct 17 '20 03:10 ProxiBlue

The dependency for magento/module-cron in version 1.0.8 of this extension should be;

"magento/module-cron": ">=100.3.5"

peterjaap avatar Oct 20 '20 12:10 peterjaap