python-for-android icon indicating copy to clipboard operation
python-for-android copied to clipboard

recipes: add new `grpcio` recipe

Open kengoon opened this issue 1 year ago • 14 comments

fix #2498

kengoon avatar May 28 '24 11:05 kengoon

@kengoon Hi!

Can we make this compatible with PyProjectRecipe?

T-Dynamos avatar May 28 '24 11:05 T-Dynamos

@T-Dynamos how? is there a guide line? Grpcio does not make use of poetry

kengoon avatar May 28 '24 13:05 kengoon

Hi @kengoon,

Our CI/CD pipeline noticed something that should not happen while building the grpcio recipe. BTW, better to ensure every new recipe build is isolated and performed via PyProjectRecipe as @T-Dynamos suggested.

Ping me when ready for the final review and a merge.

misl6 avatar May 29 '24 17:05 misl6

@misl6 PyPtojectReciepe requires pyproject.toml file right? I'm now asking how do I go about using that, the guidelines. Because grpcio does not use use pyproject.toml file

https://github.com/kivy/python-for-android/blob/5dc17e16217620daf76d58ac6d20e4f9a9d4ff8b/pythonforandroid/recipe.py#L1175

kengoon avatar May 29 '24 17:05 kengoon

@misl6 PyPtojectReciepe requires pyproject.toml file right? I'm now asking how do I go about using that, the guidelines. Because grpcio does not use use pyproject.toml file

Ouch, I see they have an issue opened for that.

@T-Dynamos , anything we can do on our side to have an isolated build without pyproject.toml ?

misl6 avatar May 29 '24 19:05 misl6

PyProjectRecipe support both build systems.

* Creating isolated environment: venv+pip...
ERROR Source /home/sompath does not appear to be a Python project: no pyproject.toml or setup.py

Also I have built this recipe locally with PyProjectRecipe and it works.

T-Dynamos avatar May 30 '24 00:05 T-Dynamos

@T-Dynamos and @misl6 Alright I will see to it. @T-Dynamos can you share a copy of the changes you made to make it work with PyProject

kengoon avatar May 30 '24 10:05 kengoon

@kengoon

Changes are in GitHub review.

T-Dynamos avatar May 30 '24 11:05 T-Dynamos

@T-Dynamos I can't see any reviews here

kengoon avatar May 30 '24 11:05 kengoon

@T-Dynamos thanks for your help with the guide on migrating to PyProjectRecipe

kengoon avatar May 31 '24 22:05 kengoon

@misl6 a nice ping for you

kengoon avatar May 31 '24 22:05 kengoon

@kengoon You forgot to include use-ndk-zlib-and-openssl-recipe-include.patch:


    patches = ["comment-getserverbyport-r-args.patch", "remove-android-log-write.patch"]

T-Dynamos avatar Jun 01 '24 03:06 T-Dynamos

@T-Dynamos oh sh*t

kengoon avatar Jun 01 '24 07:06 kengoon

@misl6 ready for you

kengoon avatar Jun 02 '24 07:06 kengoon