python-for-android icon indicating copy to clipboard operation
python-for-android copied to clipboard

Published 20 hours ago • verified publisher icon kivy

Remove redundant class variable definition from recipes

Open shyamnathp opened this issue 1 year ago • 3 comments

  • Some of the variables like call_hostpython_via_targetpython, install_in_hostpython are redifined in the package recipes with the exact same value as its parent class, making the definitions redundant. This patch removes these redefinitions.

shyamnathp avatar Dec 08 '23 13:12 shyamnathp

feel free to abandon this PR if the variables were redefined originally for readability reasons.

shyamnathp avatar Dec 08 '23 13:12 shyamnathp

Thanks for the cleanup @shyamnathp , however, the CI is failing.

The good news is that I'm 100% sure is not your fault, but in order to have a ✅ , can you please add pygame to this list ?

misl6 avatar Dec 08 '23 15:12 misl6

Thanks for the cleanup @shyamnathp , however, the CI is failing.

The good news is that I'm 100% sure is not your fault, but in order to have a ✅ , can you please add pygame to this list ?

As a part of understanding the logs, how did you figure out it was 'pygame' that was causing the crash? From the logs, I see liblzma seems to be the culprit and this does not seem to be a dependent recipe of 'pygame'

shyamnathp avatar Dec 11 '23 10:12 shyamnathp