kivy3 icon indicating copy to clipboard operation
kivy3 copied to clipboard

[WIP] Basic housekeeping

Open rnixx opened this issue 5 years ago • 5 comments

@JohnSumskas With this PR I do basic housekeeping and try to get an overview of all your enhancements. Some examples seem to be almost duplicates of others, or behave identical. Can you tell me what the depreciated folder is good for and which examples are up to date please?

rnixx avatar Apr 28 '20 11:04 rnixx

Just curious if we do need the licence in all files or in the repo root is enough?

AndreMiras avatar Apr 28 '20 12:04 AndreMiras

Its fine to remove the deprecated folder. It was just a list of old examples that were developed but I replaced them in the examples folder. Some of them don't work. I was just keeping them for reference. Everything outside the deprecated folder should be up to date.

JohnSumskas avatar Apr 28 '20 14:04 JohnSumskas

@AndreMiras you're right. I removed the license text from py source files.

rnixx avatar Apr 28 '20 18:04 rnixx

@JohnSumskas I removed the _depreciated folder from examples, fixes urdf loader example and simplifies and cleaned up urdf and stl loader examples.

rnixx avatar Apr 28 '20 18:04 rnixx

Nice that you're giving it some love, it looks promising :heart: You realise the PR is so big it makes it hard to really review? :sweat_smile: My suggestion would be, address two-three simple concerns per PR or only one concern if it's more complex. That makes it less likely to overlook something and introduce regressions. For instance:

  • one PR that simply drops examples/_depreciated and does only that
  • one PR that only deals with license clean up
  • one PR per examples/*/main.py clean up that explains what's being done and why it's needed

It's only a suggestion and I'm not maintaining this project. It feels overkill and extra work, but actually it's a strategy to get things done. For instance even though my knowledge on this project is very limited, it's still likely that I try to understand and approve/merge something as trivial as deleting a folder called _depreciated/. So that would be one step further toward getting the big task done

AndreMiras avatar May 23 '20 09:05 AndreMiras