fuel icon indicating copy to clipboard operation
fuel copied to clipboard

Add unit test for DecodeStream and EncodeStream

Open akexorcist opened this issue 3 years ago • 3 comments

Description

Add unit test to

  • DecodeStream.kt
  • EncodeStream.kt

Type of change

Check all that apply

  • [ ] Bug fix (a non-breaking change which fixes an issue)
  • [ ] New feature (a non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactoring (a change which changes the current internal or external interface)
  • [ ] This change requires a documentation update
  • [x] Add more unit test. No functionality changes

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new compiler warnings
  • [x] New and existing unit tests pass locally with my changes

akexorcist avatar Apr 11 '21 18:04 akexorcist

Codecov Report

Merging #807 (d633ef6) into master (da920c5) will increase coverage by 0.19%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #807      +/-   ##
============================================
+ Coverage     71.75%   71.95%   +0.19%     
  Complexity      302      302              
============================================
  Files            61       61              
  Lines          1519     1519              
  Branches        216      216              
============================================
+ Hits           1090     1093       +3     
+ Misses          316      313       -3     
  Partials        113      113              
Impacted Files Coverage Δ Complexity Δ
...lin/com/github/kittinunf/fuel/util/DecodeStream.kt 44.44% <0.00%> (+11.11%) 0.00% <0.00%> (ø%)
...lin/com/github/kittinunf/fuel/util/EncodeStream.kt 42.85% <0.00%> (+28.57%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da920c5...d633ef6. Read the comment docs.

codecov[bot] avatar Apr 11 '21 18:04 codecov[bot]

Is this PR ready to review ^^? ❤️

kittinunf avatar Apr 24 '21 15:04 kittinunf

Please keep this PR for a while

akexorcist avatar Apr 27 '21 16:04 akexorcist