clikan icon indicating copy to clipboard operation
clikan copied to clipboard

Adding support for multi-task operations

Open OdayMansour opened this issue 2 years ago • 4 comments

Issue #56 for context: Operating on multiple tasks

Notes: Replaced 4 @click.argument('id') with @click.argument('id', nargs=-1) to support multiple arguments. This converts arguments from strings to lists of strings so I added for id in ids loops. Moved write_data and repaint to the end of functions Added a few %s' % id to error messages to remove ambiguity when operating on multiple tasks Added tests for multi-argument test cases, tests pass on a blank .dat file but fail if re-ran without emptying .dat (due to task ids being incremental)

OdayMansour avatar May 30 '23 22:05 OdayMansour

FWIW, tests succeed on my side:

oday@xxxx:/mnt/c/Users/Oday/code/git/clikan$ CLIKAN_HOME=/tmp pytest clikan_test.py
==================================================================== test session starts ====================================================================
platform linux -- Python 3.8.10, pytest-7.3.1, pluggy-1.0.0
rootdir: /mnt/c/Users/Oday/code/git/clikan
collected 20 items

clikan_test.py ....................                                                                                                                   [100%]

==================================================================== 20 passed in 0.37s =====================================================================

OdayMansour avatar May 30 '23 22:05 OdayMansour

Looks like it is a "style" issue with flake.

https://github.com/kitplummer/clikan/actions/runs/5126987553/jobs/9222136864?pr=58#step:5:29

kitplummer avatar May 31 '23 17:05 kitplummer

I can check these out again tonight, I'll run it locally a few times to make sure.

OdayMansour avatar May 31 '23 17:05 OdayMansour

Looks good now!

OdayMansour avatar Jun 01 '23 12:06 OdayMansour