kitodo-production icon indicating copy to clipboard operation
kitodo-production copied to clipboard

Drag'n'drop error in PrimeFaces tree component used in metadata editor

Open solth opened this issue 4 months ago • 0 comments

Describe the bug The version of PrimeFaces used in Kitodo.Production was recently updated from 8 to 12. This new release contains a bug in the Tree component where the resulting position of a tree node moved via drag'n'drop from an earlier to a later location inside the same structure element is incorrect.

Note: the error does not seem to occur when moving a node in the other direction, e.g. from a later to an earlier position within the same structure element

To Reproduce Steps to reproduce the behavior:

  1. Open a process in the metadata editor
  2. Drag a page in a structure element from one position and drop it at a later position in the same element
  3. See wrong position after dropping the element

Expected behavior Tree nodes should be inserted at the correct location where they were moved via drag'n'drop actions.

Screenshots See clip in review by @thomaslow in https://github.com/kitodo/kitodo-production/pull/6591#pullrequestreview-3210799423 (Left part of that video shows bug in Kitodo with PrimeFaces 12, right part shows the same bug did not appear in the previously used version 8 of PF)

Release Current main branch after the merge of #6591

Additional context This bug is fixed in PrimeFaces 13. Updating to this version does break quite a few layouts and designs in Kitodo, though, which makes it a non-trivial task.

solth avatar Sep 19 '25 11:09 solth