kitodo-production icon indicating copy to clipboard operation
kitodo-production copied to clipboard

Scroll to recently added metadata row

Open thomaslow opened this issue 1 year ago • 1 comments

Fixes #5929

Adds Javascript to scroll to the recently added metadata row and highlights it by changing its background color.

Todo

  • [ ] Clean up code
  • [ ] Apply the same logic to other metadata tables (e.g. when creating a new process)
  • [ ] Selenium Test

Demo

https://github.com/user-attachments/assets/f07bbfd1-fa0c-4d75-9085-cb8bee49f00a

thomaslow avatar Oct 30 '24 16:10 thomaslow

@thomaslow great work! Thanks for directly putting the focus on the new element and also giving it its own style so it is even easier to directly identify!

solth avatar Oct 30 '24 19:10 solth

@thomaslow please rebase against current master. There seems to be a test failing - MetadataST.linkPageToNextDivision - after #6255 was merged.

solth avatar Nov 14 '24 08:11 solth

Perhaps we could adjust the color of the focused row in the future to something that is already used in the Kitodo color scheme.

Of course, my color choice is debatable. There is no usable existing color in the color palette of pattern-library.css. Maybe a slightly darker blue would be better?

image

The regular background uses the CSS variable --trans-blue. I added a variable --trans-blue-highlight.

thomaslow avatar Nov 15 '24 12:11 thomaslow

Maybe a slightly darker blue would be better?

Yes, I think this works a lot better. Thanks for the update.

solth avatar Nov 15 '24 13:11 solth