kitodo-production icon indicating copy to clipboard operation
kitodo-production copied to clipboard

Update PrimeFaces

Open solth opened this issue 2 years ago • 5 comments

Kitodo.Production should be updated from PrimeFaces 8 to the current version 12.

Related issues:

  • #5034

solth avatar Feb 03 '23 12:02 solth

@solth is it possible to remove the lable "improvement", cause in my option this lable misleads the need for Kitodo.Production?

markusweigelt avatar Mar 16 '23 12:03 markusweigelt

Votes: 3

solth avatar Mar 18 '24 18:03 solth

Does anybody already know which changes (in addition to updated dependencies) are required?

Update 8 -> 10.0.0:

  • signature change for method List in class LazyDataModel (LazyDTOModel.java, LazyHitModel.java)
  • signature change for method getRowKey in class LazyDataModel (LazyDTOModel.java, LazyHitModel.java)
  • signature changes for the same methods in derived classes
  • updates for callers of these methods
  • deprecated component Media (org.primefaces.component.media.Media)
  • more???

Update 10.0.0 -> 11.0.0:

  • ???

Update 11.0.0 -> 12.0.0:

  • ???

Update 12.0.0 -> 13.0.10:

  • ???

Update 13.0.0 -> 14.0.2:

  • ???

stweil avatar Jul 27 '24 07:07 stweil

@solth is it possible to remove the lable "improvement", cause in my option this label misleads the need for Kitodo.Production?

Isn't it even a bug fix because of the mentioned related issue, so the label "bug" should be added?

stweil avatar Jul 27 '24 07:07 stweil

I tried version 10.0.0 at the end of 2021, and it appeared somewhat broken. For example, FontAwesome was dropped because PrimeFaces now includes its own icons, called PrimeIcons. (Manually including FontAwesome might be an option.) You can find an overview of the changes in the "Migration Guide".

In addition to updating PrimeFaces, the Selenium tests will likely need to be adjusted since the HTML structure or selectors may have changed.

Isn't it even a bug fix because of the mentioned related issue, so the label "bug" should be added?

The label "bug" seems more relevant to the current version and might be somewhat misleading. It would be better to use "improvement" or, additionally, the label "blocking" to describe the issue accurately. In the past, some institutions have hesitated to use Kitodo.Production because it supports an outdated Java version. Updating PrimeFaces also necessitates Java Update.

markusweigelt avatar Jul 29 '24 08:07 markusweigelt