kitodo-production icon indicating copy to clipboard operation
kitodo-production copied to clipboard

Performance when saving processes with a parent

Open thomaslow opened this issue 2 years ago • 1 comments

Related Issues:

  • #5368

This pull request improves the performance when saving processes that have a parent process. It doesn't fix #5368 but removes a lot of unnecessary save operations previously triggered due to a double recursion in the ProcessService.save method.

This improves the performance for actions like "set status of process up/down". For example. for 20 selected processes (with parents) the time improves from 15.1s to 4.5s (status up) and 10.7s to 6.0s (status down).

thomaslow avatar Sep 30 '22 15:09 thomaslow

#5360 has been merged. Please resolve resulting conflicts.

solth avatar Oct 25 '22 12:10 solth

In my local environment (OS: macOS, Browser Firefox v 106.0.2) :

  • for 20 selected processes (with parents) the time improves from 43s to 19.5s when setting the processes status down and from 46s to 11.5s when setting the processes status up.
  • When creating of 54 processes (with children) the time is also reduced from 1min05s to 53s.

IkramMaalej avatar Nov 03 '22 11:11 IkramMaalej