kitekit icon indicating copy to clipboard operation
kitekit copied to clipboard

KiteView

Open xinsight opened this issue 7 years ago • 0 comments

I noticed that there is a KitePresentationViewController but no access to the containing view (KiteView?). It seems simpler and more conventional to add an animation to an existing view instead of having to deal with a nested view controller. (You also don't need to bother about retaining the view controller as a local variable.)

For example, instead of:

    guard let kitePresentationViewController = KitePresentationViewController(kiteDocument: kiteDocument) else {
        fatalError("Could not create Kite Presentation View Controller")
    }
    self.kiteViewController = kitePresentationViewController
    self.placeholderView?.addSubview(kitePresentationViewController.view)

Adding a kite animation would be:

    guard let kiteView = KiteView(with: kiteDocument) else {
        fatalError("Could not create KiteView")
    }
    self.placeholderView?.addSubview(kiteView)

Is access to the kite view on the roadmap?

xinsight avatar Mar 10 '17 16:03 xinsight