Kit Bishop

Results 57 comments of Kit Bishop

Rebased. Applied suggestions. - Found a fix to the duplication error I was having, it looks like it was https://github.com/godotengine/godot/issues/92880, but I found a way around it. The Dragger Nodes...

Fixed the stretching algorithm, it should now match BoxContainer in the case that the not-first-stretching child has a minimum size greater than its desired size. > I spotted one minor...

Rebased and removed unused includes. > Hiding a child makes the other children uses a wrong offset index, so hidden sortable children should be respected when getting the dragger's offset...

>Let's say we use offsets as a ratio which seems the best solution for this, it won't break compatibility since we can control the old behaviour in the deprecated method...

Draggers are now hidden when there is 0 or 1 child. They aren't removed since the first one is added in the constructor, and it could cause issues with duplicate.

- Rebased https://github.com/godotengine/godot/pull/90439 on this so it can be tested on the editor ui. There are some issues when docks are moved (when a child visibility changes), docks can jump...

- Rebased to fix merge conflicts after https://github.com/godotengine/godot/pull/72680 Still working on the visibility issue, - Due to the complexity and chance of regressions, I'd like to add some tests first...