Kiryl Kaveryn
Kiryl Kaveryn
@biodranik > * Do we need that search at all? It takes an important vertical space. If it complicates the implementation, it can be removed safely. It will nicely place...
@biodranik all the issues are resolved (or comments added). Also, I added some logs to the c++ methods related to this feature for better debugging - see the https://github.com/organicmaps/organicmaps/pull/7978/commits/3a76b6a6a0375780a4d7dbc6dd6eb84b62674e54
> @kirylkaveryn can you please rebase? This PR is needed for the release @rtsisyk I can rebase it only tomorrow. This PR is still need a little bit of work...
This PR now contains only the fix for the same multiple languages bug. The description was updated.
> @kirylkaveryn is this done? If we have no any notices, yes!
> I'd like to review this PR in context with files updating from the Cloud. > > What function do we call when some file was updated? > > *...
@biodranik @vng @rtsisyk So, in the last implementation, I added an ASSERT into the `LoadBokmarks` to prevent the subsequent calls of this method (and future questions).
> @kirylkaveryn ASSERT works only in debug, and is completely removed from release builds. It's better to insert `CHECK(false, ("reason"));`, or `LOG(LCRITICAL, ("reason"));` instead. Fixed!
> The similar crash in the recent beta @kirylkaveryn : > > > > ``` > > Incident Identifier: 0A55B718-742C-41FF-BFC6-9DEB3197A64A > > Distributor ID: com.apple.TestFlight > > Hardware Model: iPhone14,4...
@cyber-toad I've updated the ios part. Please, grab the last commit from here. And add the ios tag for the generation of the string. https://github.com/organicmaps/organicmaps/tree/ios/gpx-file-export-for-ios ![Simulator Screen Recording - iPhone...