Kiryl Kaveryn
Kiryl Kaveryn
> Did you test it in OSM for some features with many languages in them? I'll make a tests!
I've made some fixes to this PR - fix the bug with the user can add one language multiple times while the textfield is empty. - when the user _adds...
> On iOS the Edit Place button is sometimes disabled, and sometimes hidden. @kirylkaveryn did you observe that behavior? What's in the code? I found that there are two options...
> Maybe we should always display "Update maps" button there in such cases? Or "Update map to edit". And by tapping on the button we may open the downloading screen.
> @kirylkaveryn this is already in master, right? Yes! I'll close this PR and push some small fixes that you mentioned about the tappable area.
@jm355 @biodranik I reduced the top bar insets from 24(top from safe area)/12(bottom) to 10/10. So size was decreased by 16pt. Do you think it's enough? Before/ after. Vert: Hor:
> E.g., on devices with the safe area, can the intent from the screen edge to the text be the same, as on devices without the safe area? @biodranik it's...
@biodranik yes we can. But its bad UI to use this space (except scrolling content). Documentation says: > The safe area defines the area within a view that _isn’t covered...
> @kirylkaveryn Ok, contributors with XCode are needed. Everything works fine with this PR? @vng Build and run successfully on the simulator, iPhone device and mac (iPad designed for mac)....
@biodranik @gpesquero This bug is much deeper. Because the Settings screens were designed a long time ago and not very well, cells are using the custom titles and images over...