angular-disqus icon indicating copy to clipboard operation
angular-disqus copied to clipboard

Published 20 hours ago • verified publisher icon kirstein

Add support for SSO(Single Sign-On)

Open brunoosilva opened this issue 8 years ago • 4 comments

Hi,

Added support for SSO, for more information https://help.disqus.com/customer/portal/articles/236206-single-sign-on

Removed bower, because is not necessary.

Also, published in http://npmjs.com.

Url of package: https://www.npmjs.com/package/angular-disqus

brunoosilva avatar Oct 07 '16 17:10 brunoosilva

Hey! Could you please also remove the travis configuration for bower and make sure that the tests pass.

bower ENOENT        No bower.json present
The command "bower install" failed and exited with 1 during .

kirstein avatar Oct 09 '16 10:10 kirstein

Since im not currently maintaining this plugin anymore I also added you to contributors list. However with that in mind, could you please not bump the version for stuff unless its released to master. Pumping in pull-requests is a anti-pattern that we should overall avoid. Other than that, good job and enjoy.

kirstein avatar Oct 09 '16 10:10 kirstein

Hy @kirstein,

Thanks for the comments and add me in contributors list.

I forgot "Travis" has corrected and went.

Now I do not understand about the versions and pull-request.

Sorry I'm starting in the world of open-source :)

brunoosilva avatar Oct 09 '16 19:10 brunoosilva

Strange, I moved to the current version and the breaking test at Travis

image

brunoosilva avatar Oct 10 '16 13:10 brunoosilva