nova-chartjs icon indicating copy to clipboard operation
nova-chartjs copied to clipboard

hideFromIndex() in Laravel Nova style.

Open 4n70w4 opened this issue 4 years ago • 5 comments

Example: InlinePanel::make($this, $request, 'Chart Name')->hideFromIndex(),

4n70w4 avatar Jan 13 '21 18:01 4n70w4

@4n70w4 Thanks for the contribution! We'll take a look at this as soon as we can.

dvanscott avatar Jan 13 '21 19:01 dvanscott

@dvanscott Do you think this is necessary? we already have this as an argument in constructor

navneetrai avatar Jan 28 '21 19:01 navneetrai

All Nova fields have this method. See \Laravel\Nova\Fields\FieldElement::hideFromIndex

4n70w4 avatar Jan 29 '21 13:01 4n70w4

Passing 6+ parameters to a constructor is a bit antipattern =)

4n70w4 avatar Jan 29 '21 13:01 4n70w4

Hi! Any news?

4n70w4 avatar Oct 21 '22 19:10 4n70w4

Hi @4n70w4 we are closing this in favor of this one: https://github.com/kirschbaum-development/nova-chartjs/pull/67/ This new PR is based on your changes and we really appreciate your contribution. Sorry for the delay on this approval.

wilkerwma avatar Mar 21 '23 17:03 wilkerwma