Kirk Waiblinger
Kirk Waiblinger
Hello! Just checking whether this issue has enough common ground to be actionable with a rename to `no-useless-template-expression` and doc updates? @JoshuaKGoldberg @bradzacher @Josh-Cena
related: https://github.com/typescript-eslint/typescript-eslint/issues/8597
I think `no-unused-vars` could be added to the list, with the same pattern as `init-declarations`: ```ts // current report let unusedVar: Really & Long & { Type: 'Annotation' }; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...
> Note that we don't particularly want to break from eslint core too much in the case of extension rules. > > If eslint reports on the variable and the...
Another one: ```ts /* eslint @typescript-eslint/no-non-null-assertion: "error" */ declare const long: any; // current long.long.nested.thing.that.ends.in.a.non.null.assertion! ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ // proposed long.long.nested.thing.that.ends.in.a.non.null.assertion! ^ ```
how about this one? ```ts // eslint @typescript-eslint/consistent-type-assertions: ['error', { assertionStyle: 'as' } ] x; ^^^ // eslint @typescript-eslint/consistent-type-assertions: ['error', { assertionStyle: 'angle-bracket' } ] x as T; ^^^^ //...
> One thing I am personally a fan of is over-highlighting if it highlights the code that would be fixed by the rule. > > For example if you highlight...
I'm +1 on this. The typescript-eslint codebase itself has unnecessary `!!` that could be linted out, see https://github.com/typescript-eslint/typescript-eslint/blob/fc08f969e255b55ea35091b297b358bc434a76eb/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts#L75-L90
@skondrashov Nice work btw 🙂. It's cool to see the number of spots within the typescript-eslint codebase that get fixed by your implementation (and IMO a good demo in favor...
@kirillgroshkov > Can someone point me to an example of how this can be implemented? The source code for eslint's base rule is here https://github.com/eslint/eslint/blob/13d0bd371eb8eb4aa1601c8727212a62ab923d0e/lib/rules/func-style.js. I would use [our playground](https://typescript-eslint.io/play),...