Kirk Waiblinger
Kirk Waiblinger
> > So, I wonder if we can help the user out by supplying a custom error message for the async cases that don't directly return any, but whose type...
> Looks good to me, but I'm not sure if we have a consensus on this change. Per the discussion in https://github.com/eslint/eslint/issues/18186, checking sequence expressions is accepted as a bug...
> I think we can accept `??` and `?` operator as additional change in this PR. If we see following examples: > > ```js > if ((a, b, c ??...
@mdjermanovic @nzakas > How about deprecating enforceForLogicalOperands and introducing a new option enforceForInnerOperands (or some better name)? The current behavior remains the same. When the new option is enabled, the...
I thought about it more and I decided I liked the word "inner" in @mdjermanovic's original suggestion, so I went with `enforceForInnerExpressions`. `indirect` was just bugging me lol. In any...
@fregante > In some of my projects, I already set the type of the exception to `unknown` via global.d.ts types. Can this rule detect and accept that? This is basically...
See also https://github.com/prettier/prettier/issues/6608#issuecomment-1849578834
@auvred based on your comment, should this be "accepting prs"?
~~I'm +0.5 to this, since I've run into this as well, and been annoyed by it. The +0.5 rather than +1 is due to the fact that it's an easy...
Question - do we think that we should check this context analogously in `no-unnecessary-condition`? @bradzacher @alecmev (can spin off a new issue if it warrants nontrivial discussion) ([playground](https://typescript-eslint.io/play/#ts=5.4.2&fileType=.tsx&code=GYVwdgxgLglg9mABAQwM6oKYCcoAoAeAXIuANZhwDuYAlMWpjqovogN4BQiiA9D4hlQAbGGCgBaACYxUyAEZCM4sBnwSRKxAAEoATwAOgiFhj6JgjVB6ooJ6OLlw4i5GHGr9WQanhhUXRBhgRFwAQnwadgDuKAALLCpEFUpEAFEsBKxcAHIGbFgEbJoAbgCAXw4KjggEG0RbEDjdAGVbUQBzRABeRGybEzB27NKgkIam1oH2yLZEKuraqBQhVDgAFSxG2Ja2we7e-o7hjjycXGQV9c2J3emODiA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1tiacTJTIAhtEK0yHJgBNK%2BSpPRRE0aB2iQANOGx4ipZBWp0GzNsnxUydAEYcOSIU3oAPYtEHymqDJGWr12gC%2BIIFAA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false)) ```ts function...