Kiril Isakov comments

Results 26 comments of


                                            Kiril Isakov

Fix Django CSRF protection behind proxy automatically

> Why not modify seahub_settings.py directly instead of depending on another environment variable? @freeplant There are multiple reasons here, I think: - wiring a configuration with env variables is the...

Strip Nginx from seafileltd/seafile-mc

I agree. My Seafile instance is deployed on a personal dedicated Web server, and I too connect the seafile-mc container to external (host-level) instances of nginx and certbot (LetsEncrypt) software....

Fix broken deployment when served using HTTP behind a HTTPs proxy

nice workaround @undergroundwires! however, I'm a little surprised you didn't include a `depends:` directive to the patch service to make sure it doesn't fire before the seafile-* services

ad filtering syntax: `removeparam` modifier doesn't help to clean junk query params that are preceded by a hash (`#`)

> Where did you get this link? From their newsletter. For instance, see its last issue: https://t.nl.francetv.fr/r/?id=hc9785a1,6c509b4c,5fd1bede&p1=%40UYYMNRAcUXhUaReRIlHftNHzxSzNS0B3t5dfPCFeDjM%3D&p2=20240110&p3=459386-1664366309-2d5f2440 While redirecting to the target URL (the issue layout), you'll see the aforementioned...

ad filtering syntax: `removeparam` modifier doesn't help to clean junk query params that are preceded by a hash (`#`)

> I think that the reporter minds that a website can send the hash using `location.hash` and XHR/fetch. Thank you for the concern. There's another reason why I want my...

ad filtering syntax: `removeparam` modifier doesn't help to clean junk query params that are preceded by a hash (`#`)

> `$removeparam` can't remove it, because `#...` added by JS or just links in html contain that. Is there any other modifier, other than `removeparam` to remove hash params? If...