oreilly-downloader
oreilly-downloader copied to clipboard
New Docker image / Idea for most recent version
Hi @kirinnee
I love you wrapper and use it quite often. In the meanwhile the original project made some progress an fixed several bugs. Do you mind to publish a new Docker image?
Another, more flexible and sustainable idea. Instead of embedding the original script / repository into the image, the repo could be pulled on startup of your wrapper. Then always the newest version is available from master. And to make it awesome (actually it is already), one can add an additional parameter with a tag/branch/commit in case the newest ist not the most stable.
Of course it could also be solved my proper version and CI/CD pipelines and triggers. But this seems to be quite a bit of work.
Hi,
Thank you for your suggestion. However, pulling on startup:
- does not guarantee correctness (if the original CLI interface changes)
- breaks older versions (not reproducible)
- slows down start up time (due to the pull at start up)
How does nightly builds sound?
Hi,
Thank you for your feedback. Nighly build sounds great ;)