ws-osd-py icon indicating copy to clipboard operation
ws-osd-py copied to clipboard

hide sensitive values not working

Open iamwinq opened this issue 2 years ago • 10 comments

feature to hide sensitive info like gps, altitude and distance does not seem to work in my testing, ardupilot setup by the way.. osd

iamwinq avatar Jan 20 '23 16:01 iamwinq

Can you provide OSD file? Looks like Ardupilot is using a different icon id, that's why it doesn't work

kirek007 avatar Jan 20 '23 16:01 kirek007

Here's a short video, osd, and srt files from the end of my last flight. It's Ardupilot plane firmware. Hopefully this helps! https://drive.google.com/file/d/1s8FFXXZor7RdorVWQqW20dhkVUXKITuI/view?usp=share_link

keithluneau avatar Jan 20 '23 18:01 keithluneau

here are the files by the way https://drive.google.com/drive/folders/1XTTvcsqFXdGlyLp_f1zKYgFBAXjm48BG?usp=sharing

iamwinq avatar Jan 21 '23 01:01 iamwinq

i also tried rendering keith's video, with Hide sensitive data enabled, yet it still shows alt and distance image

iamwinq avatar Jan 21 '23 01:01 iamwinq

Hey guys, looks like hiding data works only for INAV and only for GPS and home distance. I'll try to make it works for ARDU too in the next version ;)

W dniu sob., 21.01.2023 o 02:46 iamwinq @.***> napisał(a):

i also tried rendering keith's video, with Hide sensitive data enabled, yet it still shows alt and distance [image: image] https://user-images.githubusercontent.com/95698959/213835504-253a2f8a-b0a9-40e8-83fc-9e5d2ffbb2ab.png

— Reply to this email directly, view it on GitHub https://github.com/kirek007/ws-osd-py/issues/16#issuecomment-1399143891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOKQC5P3O2QOZWPXUAVSBLWTM5YZANCNFSM6AAAAAAUBW2CQQ . You are receiving this because you commented.Message ID: @.***>

kirek007 avatar Jan 21 '23 08:01 kirek007

Hey guys, looks like hiding data works only for INAV and only for GPS and home distance. I'll try to make it works for ARDU too in the next version ;) W dniu sob., 21.01.2023 o 02:46 iamwinq @.> napisał(a): i also tried rendering keith's video, with Hide sensitive data enabled, yet it still shows alt and distance [image: image] https://user-images.githubusercontent.com/95698959/213835504-253a2f8a-b0a9-40e8-83fc-9e5d2ffbb2ab.png — Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOKQC5P3O2QOZWPXUAVSBLWTM5YZANCNFSM6AAAAAAUBW2CQQ . You are receiving this because you commented.Message ID: @.>

thanks again! Looking forward to it ;)

iamwinq avatar Jan 22 '23 00:01 iamwinq

It's not working with Betaflight either. The only thing it hides is the throttle value :D GPS Coordinate and Altitude is still showing.

endymuhardin avatar Feb 10 '23 02:02 endymuhardin

Right, I should write somewhere that only inav is supported 😁

pt., 10 lut 2023, 03:07 użytkownik Endy Muhardin @.***> napisał:

It's not working with Betaflight either. The only thing it hides is the throttle value :D GPS Coordinate and Altitude is still showing.

— Reply to this email directly, view it on GitHub https://github.com/kirek007/ws-osd-py/issues/16#issuecomment-1425077847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOKQC3KGUMMOUVAOMLCIF3WWWPEVANCNFSM6AAAAAAUBW2CQQ . You are receiving this because you commented.Message ID: @.***>

kirek007 avatar Feb 10 '23 06:02 kirek007

I don't know how osd data are structured and if it's possible, but it would be nice (in the future) to be able to select which data yout want to hide (or what data you want to display) in the generated files. Maybe it's an overkill but why not :)

WereWolfPL avatar Feb 10 '23 08:02 WereWolfPL

It would be nice if the user can supply the grid cells that they want to mask. That way the user can determine from themselves what they consider sensitive and you don't have to rely on detecting specific OSD element in the .osd files.

avsaase avatar Feb 10 '23 11:02 avsaase