Kirill Chetverikov
Kirill Chetverikov
We apply a logical range provided to `setVisibleLogicalRange` in a RAF callback, but at the same time we can modify series data via `setData`, `update` before the next RAF callback...
Hm, not sure. I think it would be better to create a new type of series like `BackgroundSeries`. Because in this case we can change the type of the first...
I know about custom formatter, but that's not what we need. We want to hide fractional part in price marks if all marks have zero fractional part, otherwise we want...
> Dont see any objections in approving & merging this one. @eugene-korobko, @kirchet any comments? Looks good for me, but we need to fix the pipeline 🙂
> Do these changes look correct? Yes. But probably we need to merge #1143 first and then bump version to `18.6.5`. Or even bump this version in #1143.
> Are we happy to jump to 18.6.5 rather than updating to the minimum required version of 16.14? Yes > If so, the latest 'current' node version is 18.7.0. Should...
Unfrortunatelly that's not so easy to implement. It'll take a lot of time, so 98% that it will not be inclueded in the 4.0 release
We already have the field to store a hovered marker id https://github.com/tradingview/lightweight-charts/blob/d4863ffc1c0988b2d9b03744d28bdfbdc2ca989e/src/api/ichart-api.ts#L53-L56 These ids can be provided via optional fileld https://github.com/tradingview/lightweight-charts/blob/d4863ffc1c0988b2d9b03744d28bdfbdc2ca989e/src/model/series-markers.ts#L33-L36 Probably we can add an additional optional field `id`...
I don't think that it's an acceptable solution. I would prefer just change the returned type from `number` to some observable value.
No, we don't have such example