Kirawi

Results 336 comments of Kirawi

It probably can't detect whether your terminal is true-color after a recent PR that added a check for it. Until it gets fixed, you can add `true-color = true` to...

What was the original reason we chose not to use `terminfo`?

I think that https://github.com/Aloso/lexical-sort might be better since it claims to support unicode. Edit: Actually, this is probably good enough.

Just to note, I think that using a `u64` would've been okay. `len()` returns a `usize` which is equivalent to `u64` on 64bit systems. Assuming that each number is equivalent...

By the way, make sure to run `cargo xtask docgen` and commit the changes to make CI pass.

I think this functionality was recently merged with https://github.com/helix-editor/helix/pull/1635

Using `rename` is probably better since `copy` will lead to the same issue. I think it would also be better to create the temp file in the cache directory.

I'm not sure. The async operation should be completed successfully before it's checked. @dead10ck

Since it's writing to the cache folder, maybe the CI doesn't allow that?

If it wasn't able to write to the cache directory, then the write operation would fail. I'm assuming that's why the file is empty.