Kiran Chandramohan
Kiran Chandramohan
The CI is fixed. Please rebase to run CI.
@alokkrsharma Can you address the CI failure? ``` /home/runner/work/flang/flang/tools/flang2/flang2exe/lldebug.cpp:2457:59: error: implicit conversion of NULL constant to 'LL_MDRef' (aka 'unsigned int') [-Werror,-Wnull-conversion] (child ? ll_create_flexible_md_node(db->module) : NULL); ^~~~ 0 /home/runner/work/flang/flang/tools/flang2/flang2exe/lldebug.cpp:2464:75: error:...
@bryanpkc can you add the above suggested changes to the PR?
@s-u CLA (contributor license agreement) is not a requirement now. If you are interested in submitting this PR please rebase, else consider closing.
@s-u Can you address @dnoan's comment above? Also could you let me know the build instructions you used for Mac?
Good to see that you are making progress here. Is sincos expected to come from libm?
`Now what would be a good way around this? Should I just set the system name to Darwin instead of iOS?` I guess for a local workaround that should be...
The llvm-project `cmake` sets the System Name to `Darwin` in iOS, so I think it should be OK. https://github.com/llvm/llvm-project/blob/db0631096e59c71b6f6b034306327b42d9184184/llvm/cmake/platforms/iOS.cmake#L3
@dnoan in case you have missed this, classic-flang-llvm-project now has a release_11x branch for supporting llvm 11.
If you have patches for M1 we will be happy to accept. There is an x86 macOS PR (https://github.com/flang-compiler/flang/pull/592)