Kip comments

Results 163 comments of

Kip

`std::string Pistache::Http::Header::Authorization::getBearerToken()` . Where art thou?

The latter. I implemented basic authorization a long time ago in #725. Don't forget to add a unit test.

Limited Performance on HTTPS server

Hey @jiankyu. I think you've identified a legitimate problem. I won't have time to write a patch in the near future, but myself and my fellow maintainers are happy to...

Limited Performance on HTTPS server

Hey @jiankyu. What I suggest doing is submitting your PR to this repository, marked as a draft, and that way as it evolves you'll have the benefit of seeing if...

Fix: In Reactor Add A Mutex To Protect HandlerList Internal Array

Thanks @dgreatwood. I've added a minor thought. Otherwise it looks fine to me, notwithstanding any feedback @Tachi107 might have.

Pistache when compiled with SSL gives SIGABRT when, its .so files are called to init a server.

Hey @thatsmeray98. Can you try building your application against the precompiled [packages](https://github.com/pistacheio/pistache?tab=readme-ov-file#ubuntu-ppa-unstable) in the PPA? Normal users shouldn't need to build from source in most situations unless they're testing changes...

Pistache when compiled with SSL gives SIGABRT when, its .so files are called to init a server.

No worries @thatsmeray98. We're working on a way of preventing this from happening again in #1146.

fix: data race on client/server shutdown

Hey @tyler92. Thanks for the PR. Question for you. Isn't `serveThreaded()` intended to not block by design?

fix: data race on client/server shutdown

Might the solution then be to change the unit tests to use the blocking version instead?

fix: data race on client/server shutdown

But isn't that the expected behaviour though? If the user requested to start the server asynchronously?

fix: data race on client/server shutdown

Ok, that makes sense. I'll wait to hear @Tachi107 and @dgreatwood's thoughts.