lokomotive icon indicating copy to clipboard operation
lokomotive copied to clipboard

Add owner_id to the external-dns documentation example

Open meyskens opened this issue 3 years ago • 4 comments

Add owner_id to the external-dns documentation example

Discovered a missing example field when doing release testing. As this is required makes the example non functional.

How to use

Read the documentation

Testing done

used in a release test

meyskens avatar Mar 09 '21 15:03 meyskens

cc @johananl

meyskens avatar Mar 09 '21 15:03 meyskens

Let's see if I can get the CI to be happy :)

meyskens avatar Mar 29 '21 07:03 meyskens

I use the cluster name for this field.

owner_id = var.cluster_name

Which is generally unique. But I don't have a strong opinion on what the value should be set to ideally.

surajssd avatar Apr 05 '21 06:04 surajssd

I agree with @surajssd

Rather than hard coding an example value lokomotive we should use a variable. The value of cluster_name seems to be a good choice, however what if two clusters are created with the same cluster name ?

ipochi avatar May 03 '21 08:05 ipochi