lokomotive
lokomotive copied to clipboard
Task: Remove resources to maintain scraping of backwards compatible; post Lokomotive 0.6.0 version.
To not break metrics scraping of Etcd, Contour, Metallb, and Rook, new Kubernetes resources are created in Lokomotive 0.6.0 version whilst keeping the old ones intact to maintain backwards compatibility.
Those resources will need to removed in the future Lokomotive release (possibly 0.7.0).
The following set of resources are effected:
Contour - ProemtheusRule. Update alertmanager-rules
object to reflect the label key app:
with value found in alertmanager-rules-for-prometheus-0-43-2
and then delete alertmanager-rules-for-prometheus-0-43-2
.
Rook - ProemtheusRule. Update prometheus-ceph-rules
object to reflect the label key app:
with value found in prometheus-ceph-rules-for-prometheus-operator-0-43-2
and then delete prometheus-ceph-rules-for-prometheus-operator-0-43-2
.
Etcd: Endpoint and Service object. Update etcd
Endpoint and Service to reflect the label key app:
with value found in etcd-updated-for-prometheus-operator-0-43-2
and then delete etcd-updated-for-prometheus-operator-0-43-2
.
Metallb - ProemtheusRule. Update alertmanager-rules
object to reflect the label key app:
with value found in alertmanager-rules-for-prometheus-0.43.2
and then delete alertmanager-rules-for-prometheus-0.43.2
.
I wonder, perhaps we could just have a commit which needs to be reverted in the next release?
I wonder, perhaps we could just have a commit which needs to be reverted in the next release?
https://github.com/kinvolk/lokomotive/pull/1162#issuecomment-733782273