lokomotive icon indicating copy to clipboard operation
lokomotive copied to clipboard

Task: Remove resources to maintain scraping of backwards compatible; post Lokomotive 0.6.0 version.

Open ipochi opened this issue 4 years ago • 2 comments

To not break metrics scraping of Etcd, Contour, Metallb, and Rook, new Kubernetes resources are created in Lokomotive 0.6.0 version whilst keeping the old ones intact to maintain backwards compatibility.

Those resources will need to removed in the future Lokomotive release (possibly 0.7.0).

The following set of resources are effected:

Contour - ProemtheusRule. Update alertmanager-rules object to reflect the label key app: with value found in alertmanager-rules-for-prometheus-0-43-2 and then delete alertmanager-rules-for-prometheus-0-43-2.

Rook - ProemtheusRule. Update prometheus-ceph-rules object to reflect the label key app: with value found in prometheus-ceph-rules-for-prometheus-operator-0-43-2 and then delete prometheus-ceph-rules-for-prometheus-operator-0-43-2.

Etcd: Endpoint and Service object. Update etcd Endpoint and Service to reflect the label key app: with value found in etcd-updated-for-prometheus-operator-0-43-2 and then delete etcd-updated-for-prometheus-operator-0-43-2.

Metallb - ProemtheusRule. Update alertmanager-rules object to reflect the label key app: with value found in alertmanager-rules-for-prometheus-0.43.2 and then delete alertmanager-rules-for-prometheus-0.43.2.

ipochi avatar Nov 25 '20 11:11 ipochi

I wonder, perhaps we could just have a commit which needs to be reverted in the next release?

invidian avatar Nov 25 '20 11:11 invidian

I wonder, perhaps we could just have a commit which needs to be reverted in the next release?

https://github.com/kinvolk/lokomotive/pull/1162#issuecomment-733782273

ipochi avatar Nov 25 '20 15:11 ipochi