Marius Kintel

Results 396 comments of Marius Kintel

Anyway, I think we can close this as an expected OOM crash, Edit: Actually, I think this is a symptom of a real issue, possible related to Manifold caching not...

@pca006132 I think this may be a good illustration of why we want https://github.com/elalish/manifold/issues/764 to be addressed.

To help illustrate where I think all the memory goes: * In this case, OpenCAD is given a very long flat list of PolySet objects and is asked to union...

Right, as a start we probably shouldn't cache nodes that are not actual OpenSCAD nodes (like intermediate nodes in a binary tree described above).

Tested this on macOS. Looks good except for the preference UI mentioned in my review. Someone should give this a spin on Windows too..

Could you add a binary file as a test?

For tests, read https://github.com/openscad/openscad/blob/master/doc/testing.txt ..and look at e.g. the OBJ file tests as an example: https://github.com/openscad/openscad/blob/master/tests/data/obj/cube.obj https://github.com/openscad/openscad/blob/master/tests/data/obj/dodecahedron.obj https://github.com/openscad/openscad/blob/55be9cf86a4059a96239e7b660481643975c8173/tests/CMakeLists.txt#L717

Looks like you're just missing parentheses for the macOS issue

Looks like the PMP issue was resolved

`allownef` means something else: It's used by the preview renderer, e.g. for the `render()` module, to request that we only return `PolySet` or `Polygon2d` geometry, since the preview renderer doesn't...