horizon-lumen icon indicating copy to clipboard operation
horizon-lumen copied to clipboard

Cannot display metrics

Open khoubeibouthour opened this issue 4 years ago • 1 comments

  • Horizon Version: 3.5
  • Laravel Version: 6.4
  • PHP Version: 7.4
  • Redis Driver & Version: predis/phpredis 6.17
  • Database Driver & Version: MySQL 8

Description:

https://localhost/horizon/metrics/jobs/App%5CJobs%5CMyJob keeps causing this fatal exception:

Message: Unable to resolve dependency [Parameter #0 [ <required> $slug ]] in class Laravel\Horizon\Http\Controllers\JobMetricsController
File: ../vendor/illuminate/container/BoundMethod.php
Line: 180
Exception: BindingResolutionException
Code: 0

Making these changes seem to fix this issue: Update ../vendor/kinsolee/horizon-lumen/routes/web.php:

// Current:
    Route::get('/metrics/jobs/{id}', 'JobMetricsController@show',['as' => 'horizon.jobs-metrics.show']);
// New:
    Route::get('/metrics/jobs/{slug}', 'JobMetricsController@show',['as' => 'horizon.jobs-metrics.show']);

Or updating ../vendor/kinsolee/horizon-lumen/src/Http/Controllers/JobMetricsController.php and changing the function argument name:

// Current:
public function show($slug)
// New
public function show($id)

Steps To Reproduce:

  • Open Horizon
  • Navigate to Metrics
  • Select a Job to see its metrics

khoubeibouthour avatar Jan 02 '21 07:01 khoubeibouthour

+1

elirenato avatar Jun 06 '21 02:06 elirenato