Bruno P. Kinoshita

Results 595 comments of Bruno P. Kinoshita

> @kinow Do you have any idea why the macos-latest, Java 11 CI would fail? The test that failed does not appear to be related to the changes made in...

@anantdamle > The CI flagged failing tests are not stemming from any code that I have touched, > How to resolve? Click on the link of the failed Travis CI...

I had to do something similar. Each node you create in your data, has two important entries, the `children` and the `state`. The first tells the library what are the...

> Merged your other PR's, so git conflicts now slightly_smiling_face Ah! Spoke too soon!

I used the [react example](https://github.com/cheton/react-infinite-tree) to implement a [vue component](https://github.com/cylc/cylc-ui/pull/345). There was a similar question asking for Angular support [here](https://github.com/cheton/infinite-tree/issues/7).

> Hi @kinow , thank you for taking the time to review this pull request. I have a question for you about the deprecated / removed methods. Since CharSequence is...

Brilliant @wodencafe ! I haven't looked at CI, but it appears to be failing. We need to confirm if it is something with this PR or if it is failing...

> resulting in overall build failure. Is there a possibility to rerun checks without committing anything else? Restarted in Travis interface the job that failed (JDK: openjdk11 Java).

@garydgregory I don't have a use case for this, so can't argue with your review. @pckeyan if you could elaborate more on your use case, or maybe others could chime...

Rebased, but looks like we had a test verifying the old behavior >[ERROR] TestPropertyConverter.testToBigDecimalDoubleConstructor:68 Incorrect BigDecimal value expected: but was: As mentioned in the JIRA issue comments.