Bruno P. Kinoshita
Bruno P. Kinoshita
@jochenw >@kinow Strongly opposed to accepting this PR: I don't have studied this in detail, but in my oppinion we'd loose thread safety here. Split methods, and similar simple stuff...
>At the time, the code used in the list, and the subsequent commits were improved, so I was concerned at the time. It seems that many problems have been solved...
> @kinow Thanks for your reminder! I just revised the code format and it passed the Travis CI. The GH Actions won't run automatically since I am a First-time contributor...
I don't feel confident enough to vote +1 on this change. It seems to fix the bug described here, and the test is passing on Travis. But I am concerned...
Normally changes where links are fixed in documentation are merged without being added to the change log, but given this change fixed links in so many files, I decided to...
> I guess if already flattened list is provided to `loadData()` then it would solve problem for 1st line. +1 We are working a similar idea. At the moment we...
Hi @zhangminglei ! Sure. Few questions from reviewing the JIRA ticket and the pull request. * Why Commons Collections? The SortedProperties uses Java collection classes to sort its keys. But...
Thanks for the clear response Minglei! And thanks for your contribution. Let's see what others think :+1:
Just had a play with Commons Configuration, and they have some code for handling loading Properties (I think I used version 1, version 2 has builders...). I suspect this feature...