Bruno P. Kinoshita
Bruno P. Kinoshita
Rebased, and re-worded the commit that said eager, to say: “Evaluate hints and resources at the workflow level, using the correct inputs.”. The docs and functions were updated in code...
I was fixing the `cwl-v1.2` repository conformance tests, following @mr-c feedback. @mr-c, your suggestion to use `EnvVarRequirement` looked interesting! I thought that would simplify things, but it actually pointed to...
>Review of CWL requirement/hint fields that can contain CWL expressions (inspired by the incomplete list at https://www.commonwl.org/user_guide/13-expressions/index.html ) Thanks! It's not hard to review the existing code and confirm these...
Hi all :wave: scikit-learn beginner here, with a little background on ML/NLP. I'm doing the MOOC, and as mentioned in #623, search for things like "!wiki Bayes error rate" on...
Haven't had time to review this change @topera. But >Note: this is my first try on open source projects, so please sorry if I'm skipping some important step on the...
Hi @DaGeRe ! Agree that code duplication is bad. But the change could perhaps be changed a little bit to make it easier to accept it in my opinion. In...
[LANG-1339]: deprecate circuit breakers and replace java.beans.PropertyListener by a Consumer<State>
Yup @britter you are definitely correct. At least if we agree on the solution, we can think about marking some methods as deprecated in the current circuit breaker (though I...
[LANG-1339]: deprecate circuit breakers and replace java.beans.PropertyListener by a Consumer<State>
>My suggestion would be to add two new classes with the fixed code (different class names), and deprecated the old classes. That way there is no need to have commons-lang...
[LANG-1339]: deprecate circuit breakers and replace java.beans.PropertyListener by a Consumer<State>
@jodastephen done. Kept the existing classes, but added new ones where the only modification is replacing `java.beans` by `java.util` equivalent classes. Existing classes were annotated with `@deprecated` with a comment...
[LANG-1339]: deprecate circuit breakers and replace java.beans.PropertyListener by a Consumer<State>
Posted to the mailing list and will wait to see if there is any further feedback. Otherwise I will merge it in the next days. Thank you @jodastephen !