Bruno P. Kinoshita

Results 595 comments of Bruno P. Kinoshita

(just saw your comment in the PR, sorry, was searching in the IDE and writing here :+1: but agree with you that that's strange to have `_` (especially if the...

>Would you like to try some of the approaches 2-4? I think any of them would be an improvement over the current situation, as long as the query still performs...

I decided to try `FROM NAMED` clauses since we already had the code for that. We actually called the function for that creating the `$fcl` variable, but without passing any...

The SonarCloud security issue reported is for a prefix URL, so that shouldn't be a blocker, I think. Ready for review again :+1:

> I can try to finish this off now that @kinow you are busy with the qtip-to-CSS PR #1324 ... That'd be great, please :D Thank you @osma!

>There is a very real possibility that the notation code is parsed as False value at some point. :+1: :point_up:

Had a look at some of the pending items of the list (excluding the first item): - `grimmlink/qtip2` Archived by maintainer. Easiest solution, IMO, is adopting Bootstrap's Popover (requires Popperjs...

Hmmm, JQuery UI also needs to be updated, I think? There are 3 CVE's against the current version we are using in Skosmos: - https://github.com/advisories/GHSA-9gj3-hwp5-pmwc - https://github.com/advisories/GHSA-j7qv-pgf6-hvh4 - https://github.com/advisories/GHSA-gpqq-952q-5327 The...

>Some of these "only" use deprecated features that are not per se dangerous and jQuery Migrate plugin (which restores old API) can be used in production for a while. See...

@osma fixing it was super easy thanks to your pointers on where to look at the code. However, not sure how to write a test for this one... our PHPUnit...