Daniel Silverstone

Results 222 comments of Daniel Silverstone

Importantly this is not a bug in `rustup` but in `Artifactory` itself. I'm happy for us to look at ways to improve `rustup` so that it doesn't trigger this problem,...

So at this time, `cargo` is out of scope for the work we're doing on the trust model for `rustup`. Again I ask that you hold off on pushing too...

Pattern based support for removing toolchains would be a fun enhancement though as you say you can script it instead. While I don't feel this *needs* to be in `rustup`...

@camelid We don't use a lot of the integration bots on this repo, so just saying in a comment you want to do this is enough. We're not a massively...

Having recently worked on something with spans where I knew it would have marks, I agree that this isn't particularly pleasant. Perhaps we could reserve usize::MAX for the synthetic "unknown"...

Hi Martin, Thank you for your contribution -- before I go further with review can you please give me some examples of where you want this kind of functionality? I've...

Your reasoning is sound and I approve of the idea. Can you let me know if/when `yaml-rust2` gets the fix? In the meantime let's hit approve and see how the...

I'd be OK with a CHANGELOG - I'd also like to ensure that this behaviour is documented in the rustdoc too if you can think of a nice way to...

As an addendum - when I think of `CHANGELOG.md` I generally speaking prefer something like `NEWS.md` since to me the changelog is the git history -- a NEWS file on...

Sorry for the delay; rustconf got in the way 😀 I don't mind enough about the name, so sure, let's go for `CHANGELOG.md` :D