Tanmay
Tanmay
The main reason for this change is to move away from `github.com/gogo/protobuf`, which is not maintained, and use `github.com/cosmos/gogoproto` instead. The upgrade was not done during the migration to 0.47...
> > The upgrade was not done during the migration to 0.47 because of the following reason > > We did move to `github.com/cosmos/gogoproto` during the 0.47 upgrade. Everything on...
The three messages MsgUpdateSystemContract : We can modify the validate basic to add the required validation MsgWhitelistErc20 : We can modify the validate basic to add the required validation MsgVoteInbound:...
With regards to evm_deposit , I am considering validating the receiver address based on coin-type, https://github.com/zeta-chain/zeta-node/blob/8da507f0cdfb5affbc5121a712670fbd1feaab11/x/crosschain/types/cctx.go#L175-L218 Which can be called at the beginning of the function `HandleEvmDeposit` https://github.com/zeta-chain/zeta-node/blob/8da507f0cdfb5affbc5121a712670fbd1feaab11/x/crosschain/keeper/evm_deposit.go#L27-L30 This Validate...
Draft pr for reference https://github.com/zeta-chain/node/pull/2707
Original issue 
I don’t think it is a big concern, - The chances of the even index being a lot lower than the actual index are almost negligible. - We have a...
In addition , to above we should also consider the following scenario . Detailing the steps below for a network with 3 observers - only 2 of the required 3...
THe original audit finding which led to this change 
The `chainId-nonce` key is not unique for two generated TSS keys. To make that happen, we would need to add the subkey to the index. 1. The first fix ensures...