jinhua luo

Results 102 comments of jinhua luo

Please fix the CI errors: https://github.com/apache/apisix/actions/runs/6357262086/job/17274627006?pr=10176

> Figured it out that the issue of CI (CLI Test (master)) failed because of this line: https://github.com/apache/apisix/blob/master/ci/linux_apisix_master_luarocks_runner.sh#L42 > > The CI test is pulling down the rockspec using the...

rewriting the url of grpc request in proxy-rewrite pluing is not supported yet. And do you set a correct grpc port of the upstream?

> > rewriting the url of grpc request in proxy-rewrite pluing is not supported yet. > > And do you set a correct grpc port of the upstream? > >...

@FlyTOmeLight 1. why do you configure proxy-rewrite to change uri? It's confusing and completely unnecessary for grpc. 2. The IP and port are transport-level stuff, which is none of the...

For grpc upstream server, the scheme must be `grpc`. If your service exposes different ports, choose the correct port for grpc only. Some of your routes use http port but...

You should split the ApisixUpstream into multiple upstream specs, one for grpc.

@FlyTOmeLight Could you confirm the route above used the upstream with the wrong scheme? @tao12345666333, please help, thanks.

@FlyTOmeLight Could you confirm this route matched the wrong upstream scheme? https://github.com/apache/apisix/issues/9240#issuecomment-1501064828 That is, you need to check the final configuration representation via admin API, if it is wrong and...

I mean, the name of this route contains "grpc", but it points to "http" upstream, is it expected or not? ![1681209860508](https://user-images.githubusercontent.com/4401042/231137606-78e0b6fd-058e-402c-a7ac-7b44d0615e12.png) ![1681209888968](https://user-images.githubusercontent.com/4401042/231137630-bb5c99bf-2680-410d-951e-0c77f7b823ea.png) If it's wrong, then you need to adjust...