kin-sdk-android icon indicating copy to clipboard operation
kin-sdk-android copied to clipboard

Generic error in GsonSingleton?

Open tangjingyuan opened this issue 5 years ago • 1 comments

Varibale effectPageType is defined as the following code snippet:

https://github.com/kinecosystem/android-stellar-sdk/blob/51e3ce6a080ff415783a9c6d47e284b6d41ac5b5/android-stellar-sdk/src/main/java/org/stellar/sdk/responses/GsonSingleton.java#L20

But in registerTypeAdapter it use AccountResponse https://github.com/kinecosystem/android-stellar-sdk/blob/51e3ce6a080ff415783a9c6d47e284b6d41ac5b5/android-stellar-sdk/src/main/java/org/stellar/sdk/responses/GsonSingleton.java#L35

@yosriz @OrenZak

tangjingyuan avatar Aug 14 '19 07:08 tangjingyuan

@tangjingyuan thanks for the issue, not sure about this issue, I see it's still existing in stellar-sdk, anyhow that's not in use in kin-sdk, so it's a very low priority issue. I'm moving it to kin-sdk for further investigation.

yosriz avatar Aug 25 '19 12:08 yosriz