kin-sdk-android icon indicating copy to clipboard operation
kin-sdk-android copied to clipboard

Dp 492 one wallet account linking api

Open drEfrati opened this issue 5 years ago • 5 comments

Main purpose (bug/feature/enhancement + description)

Add the option to link account in the Kin SDK In order to support Kinnovation One Wallet efforts, kin-sdks needs to expose the required minimum blockchain related functionality.

Technical details

  • Give the developers a way to build account linking transaction by exposing API methods.

  • Also added a methods to get all the aggregated balances, all the controlled accounts and a method to get the account data

Tests (Unit/Integ)

Add both type of tests

Documentation (Source/readme.md)

Currently no documentation was added.

drEfrati avatar Jun 03 '19 13:06 drEfrati

@yosriz , @berryve I took care of some things the you commented and I added some comments on your comments.

drEfrati avatar Jun 07 '19 04:06 drEfrati

@drEfrati WhitelistableTransaction contains getters as well

yosriz avatar Jun 13 '19 19:06 yosriz

Codecov Report

Merging #41 into master will decrease coverage by 2.53%. The diff coverage is 71.75%.

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
- Coverage      78.8%   76.26%   -2.54%     
- Complexity      523      556      +33     
============================================
  Files            69       75       +6     
  Lines          2156     2330     +174     
  Branches        170      203      +33     
============================================
+ Hits           1699     1777      +78     
- Misses          345      435      +90     
- Partials        112      118       +6
Impacted Files Coverage Δ Complexity Δ
...kin-sdk-lib/src/main/java/kin/sdk/Environment.java 100% <ø> (ø) 6 <0> (ø) :arrow_down:
.../kin/sdk/exception/DecodeTransactionException.java 0% <0%> (ø) 0 <0> (?)
...k-lib/src/main/java/kin/sdk/ControlledAccount.java 0% <0%> (ø) 0 <0> (?)
...-lib/src/main/java/kin/sdk/AbstractKinAccount.java 20% <0%> (-3.81%) 3 <0> (ø)
...store/presenter/RestoreCompletedPresenterImpl.java 100% <100%> (ø) 3 <3> (ø) :arrow_down:
...dk-lib/src/main/java/kin/sdk/WhitelistPayload.java 100% <100%> (ø) 3 <1> (?)
...ckupandrestore/backup/view/TextWatcherAdapter.java 100% <100%> (ø) 6 <6> (ø) :arrow_down:
...ckupandrestore/backup/view/BackupInfoFragment.java 100% <100%> (ø) 5 <4> (ø) :arrow_down:
...k/kin-sdk-lib/src/main/java/kin/sdk/KinClient.java 92.45% <100%> (ø) 34 <0> (ø) :arrow_down:
...-sdk-lib/src/main/java/kin/sdk/RawTransaction.java 100% <100%> (ø) 3 <3> (?)
... and 49 more

codecov[bot] avatar Jun 18 '19 07:06 codecov[bot]

@yosriz I updated the code so it will not include what we talked about. Also, merge from master. Please take a look.

drEfrati avatar Jul 21 '19 12:07 drEfrati

@drEfrati LGTM, the coverage seems odd in the codecov comment, but looking inside codecov everything seems fine.

yosriz avatar Jul 21 '19 14:07 yosriz