kin-node

kin-node copied to clipboard

submitPayment method is super slow and Throw exception as BadNonce

4

I am using @kinecosystem/kin-sdk-v2 version 0.5.0 SDK I have two issue with submitPayment method - Getting super slow response approx 2 to 3min - Sometimes get BadNonce exception ``` return...

bhaveshdaswani93

Missing "Earns" for app users: Node SDK should fail gracefully for "unknown" return code from Agora, instead of returning "success"

1

The submit transaction result only accounts for "error" or "success", and mis-handles "unknown" as "success" https://github.com/kinecosystem/kin-node/blob/4295b4fbde73714c7bd63771ca0ac066b0300f7a/src/client/internal.ts#L49 this causes the issue where if Agora or blockchain has a problem (e.g. runs...

rorymc

We've been using `kin-node` for more than a year, and just discovered an undocumented limit in the "EarnBatch" code. Had to dig into the kin-node code, to discover there was...

rorymc

Need an example in documentation

5

Need an example in documentation how to initialize an account and what do all these parameter values should be for KIN

s-a-y

In order to facilitate the easy integration of common functionality like showing a history of transactions, it would be great if the Kin Node.js SDK could expose this functionality, similar...

beeman

Please improve the readme on webhooks

2

It contains syntax errors: ``` app.use("/events", EventsHandler(events: []Event) => { ``` should be ``` app.use("/events", EventsHandler(events: Event[]) => { ``` and ``` app.use("/sign_transaction", SignTransactionHandler(req: SignTransactionRequest, resp: SignTransactionResponse) => { //...

doc-l

Webhooks assume you use express

3

If you don't use express, it's nearly impossible to use webhooks, because the webhook functionality assumes express responses: https://github.com/kinecosystem/kin-node/blob/91cb7115a8e198c293793a8de267d719a7eaa283/src/webhook/index.ts#L282 A better function signature would be to have a function that...

doc-l