django-ssl-auth icon indicating copy to clipboard operation
django-ssl-auth copied to clipboard

Authentication Backend doesn't extend ModelBackend

Open joshgordon opened this issue 9 years ago • 3 comments

This just took me most of the afternoon to track down.

Your Auth backend doesn't extend ModelBackend, which means that the permissions system doesn't work.

See this StackOverflow post.

I'm happy to open a PR later (it's a really simple fix), I just didn't want this issue to get lost before I get around to it.

joshgordon avatar Oct 03 '16 22:10 joshgordon

@joshgordon Is this issue still affecting you? I'm working with kimvais to take over the project and shifting development to my repository: https://github.com/tarkatronic/django-ssl-client-auth

I would happily accept a PR, if you're still willing, or I will likely get to this issue as well.

tarkatronic avatar Oct 13 '17 15:10 tarkatronic

I fixed it in my copy of this repo - it's a really simple fix.

from django.contrib.auth.backends import ModelBackend
....
class SSLClientAuthBackend(ModelBackend)

The second part is from this line. That should do it.

I'll try to get a pull request in this weekend.

joshgordon avatar Oct 13 '17 15:10 joshgordon

@joshgordon I've just released v2.0.0 of the package from my repository, including your fix. Let me know if this works for you!

tarkatronic avatar Oct 14 '17 19:10 tarkatronic