ember-cli-document-title icon indicating copy to clipboard operation
ember-cli-document-title copied to clipboard

Published 20 hours ago • verified publisher icon kimroen

Rename Promise to a different name

Open patocallaghan opened this issue 5 years ago • 2 comments

This was a weird one 😄

I bumped to 0.4.0 from 0.3.3 and noticed some of my tests were failing even though they had nothing to do with ember-cli-document-title. Turns out that var Promise was clobbering window.Promise which caused issues. Because the addon code is in a vendor file it just gets inlined as is into the vendor.js which means any variables defined here are global. Here I've renamed Promise to RSVPromise to prevent any clobbering.

patocallaghan avatar Feb 08 '19 13:02 patocallaghan

I recommend submitting your pull request at https://github.com/mike-north/ember-cli-document-title until the owner of this repo responds.

scottwernervt avatar Feb 11 '19 15:02 scottwernervt

Oh thanks, I didn't know that existed. I'm using my own fork atm too

patocallaghan avatar Feb 11 '19 15:02 patocallaghan