ember-cli-document-title
ember-cli-document-title copied to clipboard
Rename Promise to a different name
This was a weird one 😄
I bumped to 0.4.0 from 0.3.3 and noticed some of my tests were failing even though they had nothing to do with ember-cli-document-title. Turns out that var Promise
was clobbering window.Promise
which caused issues. Because the addon code is in a vendor file it just gets inlined as is into the vendor.js which means any variables defined here are global. Here I've renamed Promise
to RSVPromise
to prevent any clobbering.
I recommend submitting your pull request at https://github.com/mike-north/ember-cli-document-title until the owner of this repo responds.
Oh thanks, I didn't know that existed. I'm using my own fork atm too