ember-cli-autoprefixer icon indicating copy to clipboard operation
ember-cli-autoprefixer copied to clipboard

Published 20 hours ago • verified publisher icon kimroen

Incorrect ordering

Open stefanpenner opened this issue 7 years ago • 4 comments

Something seems funky. By default, it appears that ember-cli-autoprefixer is run after minification of css. This results in comment based autoprefixer declarations such as /*! autoprefixer: */` not making their way down to autoprefixer.

h2. Questions:

  • is it possible to move this to a preprocess step, but using after/before clause in addons package.json, ensure it happens at the right phase? Specifically other addons such as ember-cli-eyeglass etc would need to declare ^
  • does ember-cli need a hook/milestone to have this run explicitly before minification?

stefanpenner avatar Jun 07 '18 16:06 stefanpenner

@stefanpenner did you ever get this resolved? I'm quite interested in using this for a client project ...

acorncom avatar Jul 25 '18 23:07 acorncom

Based on https://github.com/kimroen/ember-cli-autoprefixer/pull/39 it seems like ensuring this runs before minification/fingerprinting would be helpful ...

acorncom avatar Jul 25 '18 23:07 acorncom

Do we need a before entry for broccoli-clean-css?

https://github.com/shinnn/broccoli-clean-css

snewcomer avatar Apr 18 '20 20:04 snewcomer

I believe that's what @stefanpenner found (though he should correct me if my memory is wrong)

nlfurniss avatar May 27 '20 05:05 nlfurniss