url-to-image icon indicating copy to clipboard operation
url-to-image copied to clipboard

Published 20 hours ago • verified publisher icon kimmobrunfeldt

Requesting V1.1

Open devasur opened this issue 8 years ago • 7 comments

Mind cutting a new version for this great library? Your latest feature additions - crop and image quality is not getting pulled when pulled via npm. This probably is because the version was not bumped when you made these feature changes.

devasur avatar Feb 28 '16 03:02 devasur

@devasur Check out my fork :

Fixed flow/logic to make maxTimeout behave correctly, but then got started on async checks + page termination corrected (still give time for new requests) + callback and event listener corrections and other misc things.

cjpetrus avatar Feb 28 '16 17:02 cjpetrus

Ahh those sound very good to have. @kimmobrunfeldt mind testing the pull request and cutting a version 1.1?

devasur avatar Feb 29 '16 03:02 devasur

@devasur https://github.com/cjpetrus/url2img

cjpetrus avatar Feb 29 '16 03:02 cjpetrus

I'll try to release those asap. @cjpetrus sounds good, would you be willing to create a PR of those fixes for this repo? This repo is still being maintained.

kimmobrunfeldt avatar Feb 29 '16 17:02 kimmobrunfeldt

@kimmobrunfeldt There's a pull request in there I already made :)

cjpetrus avatar Mar 04 '16 04:03 cjpetrus

Forgive my ignorance here, is jpeg supported yet? Having trouble getting that working but its listed in the docs. If its not supported yet, can we removing it from docs?

LMS007 avatar Mar 11 '16 23:03 LMS007

@LMS007 Check my repo for working jpeg functionality. https://github.com/cjpetrus/url2img

cjpetrus avatar Mar 13 '16 11:03 cjpetrus