aor-loopback icon indicating copy to clipboard operation
aor-loopback copied to clipboard

Improvements for Loopback Integrations

Open zeerobug opened this issue 6 years ago • 2 comments

Hi Kimkha,

This is a fork for:

  • Modified authClient to integrate AUTH_GET_PERMISSIONS case
  • Added DELETE_MANY case for full compatibility with react-admin list view
  • Added UPDATE_MANY (untested) There is a pending TODO to integrate Loopback side functions as hooks, which I can't do right now.

Thank you for your work !

zeerobug avatar Jul 10 '18 09:07 zeerobug

Thank you for your hard work and PR.

I have a question: why don't you just use default User model for authentication? Why must you create new model called Customer on your Loopback?

I think it's good for this plugin if we make this plugin simple: We have a default authentication which greatly integrate to default Loopback, and user can change to custom authentication url for themselves if they want.

kimkha avatar Jul 10 '18 15:07 kimkha

Hi,

You are right, we have to keep it simple, I just copied and paste my function. I use customer because I needed to extend the default model. Please modify the README as you wish.

Cheers, Thomas

On 10 Jul 2018, at 17:23, Nguyễn Kim Kha [email protected] wrote:

Thank you for your hard work and PR.

I have a question: why don't you just use default User model for authentication? Why must you create new model called Customer on your Loopback?

I think it's good for this plugin if we make this plugin simple: We have a default authentication which greatly integrate to default Loopback, and user can change to custom authentication url for themselves if they want.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kimkha/aor-loopback/pull/19#issuecomment-403862758, or mute the thread https://github.com/notifications/unsubscribe-auth/ASTa9fEMi5fvY1ksShWiL7MkO8wB9aNGks5uFMbjgaJpZM4VJC4r.

zeerobug avatar Jul 11 '18 06:07 zeerobug