transformer-xl icon indicating copy to clipboard operation
transformer-xl copied to clipboard

Published 20 hours ago • verified publisher icon kimiyoung

is this a bug in pytorch code on invocation of `_update_mems`?

Open misssprite opened this issue 5 years ago • 1 comments

On the invocation of _update_mems(self, hids, mems, qlen, mlen), swap of parameters seems a typo? https://github.com/kimiyoung/transformer-xl/blob/44781ed21dbaec88b280f74d9ae2877f52b492a5/pytorch/mem_transformer.py#L733 https://github.com/kimiyoung/transformer-xl/blob/44781ed21dbaec88b280f74d9ae2877f52b492a5/pytorch/mem_transformer.py#L619

misssprite avatar Apr 13 '19 14:04 misssprite

same doubts!!!

lujiarui-iie avatar Nov 11 '23 09:11 lujiarui-iie