bkcrack icon indicating copy to clipboard operation
bkcrack copied to clipboard

Clarify description of -x option

Open magnumripper opened this issue 3 years ago • 3 comments

I had to look at the source to be sure that in -x offset data, the offset is written in decimal.

While at it, it would be nice if you could say -x 0x100 instead of -x 256, such as using %i with scanf().

magnumripper avatar Aug 16 '21 17:08 magnumripper

Hello, thank you for your suggestion.

it would be nice if you could say -x 0x100 instead of -x 256, such as using %i with scanf().

This is already supported. It is a feature of std::stoi when the base argument is 0. I agree I should document this somewhere.

kimci86 avatar Aug 16 '21 18:08 kimci86

BTW, -x -1 XX doesn't work in v.1.3.2. Still worked in v.1.3.1.

cxzstuff avatar Nov 07 '21 09:11 cxzstuff

BTW, -x -1 XX doesn't work in v.1.3.2. Still worked in v.1.3.1.

Nice catch, thank you. (I need to add automated testing.)

kimci86 avatar Nov 08 '21 20:11 kimci86