wok
wok copied to clipboard
Update m2crypto dependency for Ubuntu
Pull Request Template
Description
Updated python-m2crypto to python3-m2crypto, Python 3 is now the default for Ubuntu 20.
Fixes # (issue) https://github.com/kimchi-project/wok/issues/300
How Has This Been Tested?
Updated dependencies.yaml and built from source.
Thank you for this!
Should the debian list also be updated?
And could you run make
to get README.md updated as well?
Build absolutely worked for me. The check you failed must be on their end (looking for some dependency that isn't actually required for the build).
The build fails for Ubuntu 18 (Which is what the test ran) but not Ubuntu 20. Been meaning to look into it further.
Will try look at that again and update the readme file.
Thank you for this!
Should the debian list also be updated? And could you run
make
to get README.md updated as well?
I don't know the best way to approach this issue, but I understand what is happening now.
Ubuntu 18 (what Github checks is using) does not have the package python3-m2crypto, Ubuntu 20 which is what I was using to build does have the package python3-m2crypto.
https://packages.ubuntu.com/search?keywords=python3-m2crypto&searchon=names is only available for Ubuntu 20.
This means if we pulled this commit in, it would break for anyone not running Ubuntu 20. I haven't encountered this type of issue before what is the best approach?
Is there a correct way to have the requirements split out for different versions of Ubuntu for example?