Graham Sanderson

Note that people using the SDK CMake build get pico_printf by default.

thanks; if i recall there is a count of pins used somewhere also (that are set to PIO) which is probably wrong too.

https://www.raspberrypi.org/forums/viewtopic.php?f=145&t=316310 apparently cmake 3.20.X _does_ fix this issue

boot_stage2 build in the SDK does not link against FreeRTOS-Kernel and so would not include this define (so i'd say to that extent this is a bug in rules_pico) There...

In the interim, you can add `-Wno-unused-parameter` as it is not the most aggregious warning.

We check pico-sdk with ``` -Werror -Wall -Wextra -Wnull-dereference -Wuninitialized -Wunused -Wcast-align -Wall -Wcast-qual -Wfloat-equal -Wmissing-format-attribute -Wconversion -Wsign-compare ``` If you are seeing issues with -Winline, that is a bug...

> It is perhaps worth noting that adding > > `add_compile_options(-Wall -Wextra -Wnull-dereference)` > > to pico-examples/CMakeLists.txt and compiling all the examples results in many warnings within pico-sdk. I haven't...

it is also helpful to indicate your compiler version, since the warnings generated differ wildly between them

Ok i checked, and in building the examples there are some warnings in the examples themselves (and yes they should be fixed, but hasn't been gotten to yet), but none...

fixes #970