Adam Borowski

Results 80 comments of Adam Borowski

I've packaged it for Debian, and a certain derivative known as Ubuntu will freeze soon, thus it'd be nice to have a release tagged.

The current state is good enough, thus all that's needed is a tag...

Not entirely sure where the EINTR comes from, as the manpage doesn't list EINTR as a valid return from msync(), and neither vfs, ext4 nor ecryptfs code uses it unless...

As discussed with @marcinslusarz — current `PMEM_NO_FLUSH` is supposed to be a debug-only variable for now, thus I'm not talking to **eatmydata**'s maintainer yet. Let's thus think what a good...

Implementation is trivial, it's a design issue. Either we bless PMEM_NO_FLUSH as official non-debug variable, working with libpmem1 and libpmem2, or add a new one for this purpose.

@tuliom: ping, these failures block migration in Debian and Fedora. Do you have any luck investigating these?

A different idea: instead of failing with an obvious-to-human reason, let's check for valgrind's sanity in the place we check for its presence. If it produces false positives for any...

Sounds good to me. While I believe it should be a whole distinct mode, that train has probably sailed long ago. Thanks for pointing out `ndctl list -X` — we...

MD5 is so broken it allows computational complexity attacks: that is, a malicious user who can give you a bunch of files can force fdupes into comparing a large number...

What about placing a flock() on the save file — or possibly on a separate lock file? If the lock fails, you can write a message then exit. Such locks...