dennis zhuang comments

Results 377 comments of


                                            dennis zhuang

Feature request: atomic write on local fs

I think the exclusive writing is not the object store's responsibility, it should be guaranteed by the API user.

Feature request: atomic write on local fs

Using `atomic_write_dir: Option` is a better idea. Thanks for the advice. > * `rename` is an atomic operation only when the `src` and `dst` paths are on the same fs....

Prepared statement support in MySQL and PostgreSQL

The final PR was merged https://github.com/GreptimeTeam/greptimedb/pull/1813 We can close this issue right now, thanks to all of you.

Move common dependencies to workspace dep

@waynexia Looks like we have already done this refactor?

feat: add `rate()` udf

@discord9 Can you fix the conflicting files?

Tracking Issue: migrate Arrow/Parquet to the official implementation.

What's the status of this tracking issue right now? Can we close it or keep it? @evenyag @v0y4g3r

Upgrade arrow and datafusion dependencies

This error still happens: ``` thread 'predicate::tests::test_or' panicked at 'called `Result::unwrap()` on an `Err` value: ExternalFormat("Invalid Parquet file. Corrupt footer")', src/table/src/predicate.rs:140:18 ```

Consider catalog name and schema name in old APIs

Looks like already fixed.

Set default values when loading config file

I think it's resolved in https://github.com/GreptimeTeam/greptimedb/pull/820 Already added `#[serde(default)]` for all configurations.